Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip positioning #113

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Fix tooltip positioning #113

merged 2 commits into from
Dec 16, 2021

Conversation

anitnilay20
Copy link
Contributor

PR Details

Description

  • Fix menu component popup not opening.
  • Remove rc-tooltip from dependency.
  • Remove console.log across repo.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Asutosh989
Asutosh989 previously approved these changes Dec 9, 2021
* Fix menu component popup not opening.
* Remove `rc-tooltip` from dependency.
* Remove `console.log` across repo.
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #113 (053394d) into master (23262af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         139      139           
  Lines        2195     2196    +1     
  Branches      526      527    +1     
=======================================
+ Hits         1971     1972    +1     
  Misses        224      224           
Impacted Files Coverage Δ
src/components/DatePicker/TimePicker.tsx 86.71% <ø> (-0.11%) ⬇️
src/components/Menu/Menu.tsx 85.00% <ø> (ø)
src/components/List/ListItem.tsx 100.00% <100.00%> (ø)
src/components/Menu/MenuItem.tsx 100.00% <100.00%> (ø)
src/components/Tooltip/Tooltip.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23262af...053394d. Read the comment docs.

@anitnilay20 anitnilay20 merged commit 374fe01 into master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants