Skip to content

Conversation

@yizhang2077
Copy link
Collaborator

@yizhang2077 yizhang2077 commented May 19, 2025

Motivation

current main branch server will crash when call /stop_profile api. It will raise error like this:

await _global_state.tokenizer_manager.stop_profile()
TypeError: object NoneType can’t be used in ‘await’ expression

I think it is introduced in #4741 , which forgot to remove sync stop_profile function, which will cover async version, and engine and http_server have adopt to async stop_profile version.

Modifications

Checklist

@yizhang2077 yizhang2077 changed the title fix stop_profile crash [WIP] fix stop_profile crash May 19, 2025
@yizhang2077 yizhang2077 changed the title [WIP] fix stop_profile crash [BUG] fix stop_profile crash May 19, 2025
@zhyncs zhyncs merged commit b06215d into main May 20, 2025
32 of 42 checks passed
@zhyncs zhyncs deleted the fix-stop-profile-crash-bug branch May 20, 2025 00:30
Layssy pushed a commit to Layssy/sglang-iaas that referenced this pull request Jun 9, 2025
xwu-intel pushed a commit to xwu-intel/sglang that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants