[CI] Remove unused imports with Ruff to pre-commit config, only to benchmarks/docs/examples folder

[b8zhong]

Motivation

As I read #3938, and #3963, I thought to look at what exactly the pre-commit hooks exactly were in this repository. However, the current ones (isort, etc) do not check for unused imports. I am 95% sure that it does not exist in this repo.

Modifications

• Run ruff F401 only on benchmark/ docs/ examples/, since it looks like it breaks something in CI :(

Closes #3938

Checklist

• Format your code according to the Code Formatting with Pre-Commit.
• Add unit tests as outlined in the Running Unit Tests.
• Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.

[b8zhong]

cc @HaiShaw @lcskrishna: since you guys were in the original thread, I thought you might want to take a look.

[b8zhong]

Lint failures are from adding removing unused imports (there are lots). Can go ahead and fix it if needed

[zhyncs]

@b8zhong yeah please fix it

[b8zhong]

@zhyncs Could you approve the workflow -- thanks.

Looks good on my side:

check for broken symlinks............................(no files to check)Skipped
detect destroyed symlinks................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check toml...........................................(no files to check)Skipped
check python ast.........................................................Passed
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check that scripts with shebangs are executable..........................Passed
detect private key.......................................................Passed
debug statements (python)................................................Passed
don't commit to branch...................................................Passed
isort....................................................................Passed
black-jupyter............................................................Passed
nbstripout...........................................(no files to check)Skipped
ruff.....................................................................Passed
[remove-unused-imports 43d8945a] remove unused imports
 75 files changed, 26 insertions(+), 169 deletions(-)

[zhyncs]

Nice!

[b8zhong]

Actually, it's being weird. Give me a second...

ci failed

[b8zhong]

@zhyncs Could you run the workflow again? I excluded ipynb since they were being weird with CI.. trying to fix any remaining errors on CI that I can't catch locally.

[b8zhong]

Thanks for running; gonna try to fix the rest of them later -- a bit new to this codebase. If you find ones that look suspicious, let me know...

I think vllm._C and Engine might be it... + dynamic imports

[b8zhong]

@zhyncs Thanks for the help -- could you run it once again?

It was because I removed an import that existed for backwards compatibility (all CI errors look like this, so it should be the only change that made a difference)

Traceback (most recent call last):
  File "/public_sglang_ci/runner-b-gpu-67/_work/sglang/sglang/test/srt/models/lora/test_lora.py", line 20, in <module>
    from sglang.test.runners import HFRunner, SRTRunner
  File "/public_sglang_ci/runner-b-gpu-67/_work/sglang/sglang/python/sglang/test/runners.py", line 25, in <module>
    from sglang.srt.server import Engine
ImportError: cannot import name 'Engine' from 'sglang.srt.server' (/public_sglang_ci/runner-b-gpu-67/_work/sglang/sglang/python/sglang/srt/server.py)

[zhaochenyang20]

@b8zhong Could you fix all the conflicts?

[b8zhong]

@zhaochenyang20 @zhyncs Could one of you re run the workflow again? Thanks again -- I think this should do it maybe

[zhaochenyang20]

@b8zhong thanks for your contribution. rerun alreay

[b8zhong]

@zhaochenyang20 Great -- let me know if something broke, I think I only see this

[zhaochenyang20]

CC @simveit could help to review this?

[simveit]

sure

[simveit]

LGTM.

@b8zhong is there a way you can somehow make it work with pre commit hook. it would be nice to have that.

[b8zhong]

@simveit Yes, done in 9855add

[simveit]

can we rerun CI and see if it doesnt fail @zhaochenyang20

[zhaochenyang20]

can we rerun CI and see if it doesnt fail @zhaochenyang20

do it!

[b8zhong]

Hm looks like the examples directory was touched or something which is why it failed...

I reran precommit just now

@zhaochenyang20 If you could trigger it one more time...

Thanks

[b8zhong]

Not sure why the backend test is failing here

[zhaochenyang20]

Author

let me rerun, do not rebase.

[b8zhong]

CI error is 429 Client Error: Too Many Requests

So I think it's unrelated