Conversation
github-actions
Bot
added
the
dependencies
Collaborator
Author
|
/rerun-test test/registered/lora/test_lora_qwen3_8b_logprob_diff.py |
Collaborator
Author
|
/rerun-test test/registered/attention/test_flash_attention_4.py |
Contributor
|
🚀 |
Contributor
|
🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the flash-attn-4 dependency in pyproject.toml by adding the [cu13] extra. The reviewer recommended pinning this dependency to a specific version rather than leaving it unconstrained to ensure build stability and reproducibility.
Fridge003
changed the title
Collaborator
Author
|
/rerun-test test/registered/lora/test_lora_qwen3_8b_logprob_diff.py |
Contributor
|
🚀 |
Collaborator
Author
|
/rerun-test test/registered/lora/test_lora_qwen3_8b_logprob_diff.py |
Contributor
|
🚀 |
Collaborator
Author
|
/tag-and-rerun-ci |
Kangyan-Zhou
added a commit
to Kangyan-Zhou/sglang
that referenced
this pull request
May 21, 2026
PR sgl-project#25576 bumped nvidia-cutlass-dsl[cu13] from 4.5.0 to 4.5.1. The bump exposed a latent file-level conflict between -libs-base and -libs-cu13 (both written by the additive [cu13] extra) as a hard GPUModuleOp TypeError on H100: -libs-cu13's pybind11 binding changed to the new MLIR-style ((operation: object)) without a matching bump to the Python wrapper in nvidia-cutlass-dsl, so loading -libs-cu13's .so makes the wrapper's old-style super().__init__() call fail. Two changes: 1. Revert the version bump (4.5.1 -> 4.5.0). At 4.5.0 both .so files expose a compatible binding, so the same coexistence no longer crashes. This removes the active TypeError on H100 and on the CUDA-13 Docker image for non-Blackwell users. 2. Add fix_cutlass_dsl_libs() to ci_install_dependency.sh, called from main() after download_flashinfer_cache. The function picks the right libs package per GPU family even at 4.5.0 to avoid two independent regressions that the silent conflict could still hit: Blackwell (IS_BLACKWELL=1, CU13): Purge -libs-base, force-reinstall -libs-cu13 so its files take precedence. -libs-base is CUDA-12.9-built and lacks the sm_110 arch alias that GB300/B200 need at cutlass import time. Non-Blackwell CU13 (H100, H200): Purge -libs-cu13, force-reinstall -libs-base. -libs-cu13 carries a CUDBG_EXCEPTION_WARP_ILLEGAL_ADDRESS regression in LoRA CUDA- graph capture on sm_90 (sgl-project#25743 / reverted by sgl-project#25756). Non-CU13: no-op (only -libs-base ever installed).
Kangyan-Zhou
added a commit
to Kangyan-Zhou/sglang
that referenced
this pull request
May 21, 2026
Revert the version bump from PR sgl-project#25576. At 4.5.1, -libs-cu13's pybind11 binding changed to new MLIR-style ((operation: object)) without a matching bump to the Python wrapper in nvidia-cutlass-dsl, exposing the latent file-level conflict between -libs-base and -libs-cu13 (both written by the additive [cu13] extra) as a hard GPUModuleOp TypeError at kernel-compile time on CU13 runners. At 4.5.0 both .so files expose a compatible binding, so the same coexistence is silent and CI was empirically green on H100 and Blackwell during the post-sgl-project#25756, pre-sgl-project#25576 window. Going back to 4.5.0 restores that state. Supersedes sgl-project#25935 (which proposed the same revert but was closed).
Shunkangz
pushed a commit
to Shunkangz/sglang
that referenced
this pull request
May 27, 2026
alphabetc1
pushed a commit
to alphabetc1/sglang
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Which might fix the error mentioned in #25743
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #26087085502⚠️ Not enabled -- add
Latest PR Test (Extra):
run-ci-extralabel to opt in.