Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve the parents dimention #18

Open
timothymillar opened this issue Apr 10, 2024 · 1 comment
Open

Reserve the parents dimention #18

timothymillar opened this issue Apr 10, 2024 · 1 comment

Comments

@timothymillar
Copy link
Collaborator

Should we make parents a reserved dimension name? The size could be specified as "The number of unique parental categories used in the VCF header". So the following header lines would correspond to a dimension size of 3 (['Original', 'Father', 'Mother']).

##PEDIGREE=<ID=TumourSample,Original=GermlineID>
##PEDIGREE=<ID=SomaticNonTumour,Original=GermlineID>
##PEDIGREE=<ID=ChildID,Father=FatherID,Mother=MotherID>

Related to sgkit-dev/sgkit#1013
@jeromekelleher
Copy link
Contributor

Sure, I don't see any harm in reserving it for later use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromekelleher @timothymillar