Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Trino #438

Open
romanzdk opened this issue Jan 27, 2023 · 4 comments
Open

Support for Trino #438

romanzdk opened this issue Jan 27, 2023 · 4 comments

Comments

@romanzdk
Copy link

Please add support for Trino SQL engine

@antonysouthworth-halter
Copy link

+1 on this, I feel like it should not be too difficult given there is already the official DBAPI wrapper https://github.com/trinodb/trino-python-client

@zeddit
Copy link

zeddit commented Aug 21, 2023

+1, but it seems trino is using http as interface, thus won't be accelerated too much.

@wseaton
Copy link
Collaborator

wseaton commented Aug 21, 2023

Here's an example Trino Rust client implementation: https://github.com/joshthoward/trino-rust-client, it's basically just a wrapper around a few REST API calls. There are also very tricky things like supporting OAuth and automatically de-serializing the data into an Arrow table format that are absent.

Benchmarking that (as the best case) against the python bindings might show if there is a room for speedup, but I doubt much is to be gained.

@domnikl
Copy link
Contributor

domnikl commented Sep 6, 2024

Trino support was added in 0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants