Skip to content

Commit ac3ab20

Browse files
committed
dont use progress dialog to block key input
2 parents b9a15fd + 5b7b481 commit ac3ab20

37 files changed

+82
-16
lines changed

components/Buttons/JFButtons.bs

+1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ end sub
102102

103103
function onKeyEvent(key as string, press as boolean) as boolean
104104

105+
if m.top.getScene().disableRemote then return false
105106
if not press then return false
106107

107108
if key = "left"

components/Buttons/SlideOutButton.bs

+2
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ sub onPaddingChanged()
8888
end sub
8989

9090
function onKeyEvent(key as string, press as boolean) as boolean
91+
92+
if m.top.getScene().disableRemote then return false
9193
if not press then return false
9294

9395
if key = "OK" and m.top.hasFocus()

components/ItemGrid/Alpha.bs

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ end sub
1010

1111
function onKeyEvent(key as string, press as boolean) as boolean
1212

13+
if m.top.getScene().disableRemote then return false
1314
if not press then return false
1415

1516
if key = "OK"

components/ItemGrid/ItemGrid.bs

+3
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,9 @@ function getItemFocused()
757757
end function
758758

759759
function onKeyEvent(key as string, press as boolean) as boolean
760+
761+
if m.top.getScene().disableRemote then return false
762+
760763
if not press then return false
761764

762765
if m.itemGrid.opacity = 1

components/ItemGrid/ItemGridOptions.bs

+3
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,9 @@ sub saveFavoriteItemSelected(msg)
247247
end sub
248248

249249
function onKeyEvent(key as string, press as boolean) as boolean
250+
251+
if m.top.getScene().disableRemote then return false
252+
250253
if key = "down" or (key = "OK" and m.buttons.hasFocus())
251254
m.buttons.setFocus(false)
252255
m.menus[m.selectedItem].setFocus(true)

components/ItemGrid/MovieLibraryView.bs

+3
Original file line numberDiff line numberDiff line change
@@ -834,6 +834,9 @@ sub onChannelSelected(msg)
834834
end sub
835835

836836
function onKeyEvent(key as string, press as boolean) as boolean
837+
838+
if m.top.getScene().disableRemote then return false
839+
837840
if not press then return false
838841

839842
if key = "left" and m.voiceBox.isinFocusChain()

components/ItemGrid/MusicLibraryView.bs

+2
Original file line numberDiff line numberDiff line change
@@ -699,6 +699,8 @@ sub onChannelSelected(msg)
699699
end sub
700700

701701
function onKeyEvent(key as string, press as boolean) as boolean
702+
703+
if m.top.getScene().disableRemote then return false
702704
if not press then return false
703705

704706
if key = "left" and m.voiceBox.isinFocusChain()

components/JFScene.bs

+2-15
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,9 @@ sub isLoadingChanged()
1111
m.spinner.visible = m.top.isLoading
1212
end sub
1313

14-
' Triggered when the disableRemote boolean component field is changed
15-
sub disableRemoteChanged()
16-
if m.top.disableRemote
17-
dialog = createObject("roSGNode", "ProgressDialog")
18-
dialog.id = "invisibiledialog"
19-
dialog.visible = false
20-
dialog.opacity = 0
21-
m.top.dialog = dialog
22-
else
23-
if isValid(m.top.dialog)
24-
m.top.dialog.close = true
25-
end if
26-
end if
27-
end sub
28-
2914
function onKeyEvent(key as string, press as boolean) as boolean
15+
16+
if m.top.disableRemote then return false
3017
if not press then return false
3118

3219
if key = "back"

components/JFScene.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<Spinner id="spinner" translation="[897, 477]" visible="false" />
77
</children>
88
<interface>
9-
<field id="disableRemote" type="boolean" value="false" onchange="disableRemoteChanged" />
9+
<field id="disableRemote" type="boolean" value="false" />
1010
<field id="isLoading" type="boolean" value="false" onchange="isLoadingChanged" />
1111
<field id="exit" type="boolean" alwaysNotify="true" />
1212
</interface>

components/RadioDialog.bs

+2
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ sub onContentDataChanged()
117117
end sub
118118

119119
function onKeyEvent(key as string, press as boolean) as boolean
120+
121+
if m.top.getScene().disableRemote then return false
120122
if key = "right"
121123
' By default RIGHT from the option list selects the OK button
122124
' Instead, keep the user on the option list

components/config/LoginScene.bs

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ end sub
55

66
function onKeyEvent(key as string, press as boolean) as boolean
77
' Returns true if user navigates to a new focusable element
8+
9+
if m.top.getScene().disableRemote then return false
10+
811
if not press then return false
912

1013
list = m.top.findNode("configOptions")

components/config/SetServerScreen.bs

+3
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ sub init()
1717
end sub
1818

1919
function onKeyEvent(key as string, press as boolean) as boolean
20+
21+
if m.top.getScene().disableRemote then return false
22+
2023
m.log.debug("SetServerScreen onKeyEvent", key, press)
2124

2225
if not press then return true

components/home/HomeRows.bs

+3
Original file line numberDiff line numberDiff line change
@@ -557,6 +557,9 @@ sub itemSelected()
557557
end sub
558558

559559
function onKeyEvent(key as string, press as boolean) as boolean
560+
561+
if m.top.getScene().disableRemote then return false
562+
560563
if press
561564
if key = "play"
562565
print "play was pressed from homerow"

components/keyboards/IntegerKeyboard.bs

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ sub init()
33
end sub
44

55
function onKeyEvent(key as string, press as boolean) as boolean
6+
7+
if m.top.getScene().disableRemote then return false
8+
69
if key = "back"
710
m.top.escape = key
811
return true

components/liveTv/ProgramDetails.bs

+2
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,8 @@ sub onAnimationComplete()
316316
end sub
317317

318318
function onKeyEvent(key as string, press as boolean) as boolean
319+
320+
if m.top.getScene().disableRemote then return false
319321
if not press then return false
320322

321323
if key = "OK" and m.viewChannelButton.hasFocus()

components/liveTv/schedule.bs

+2
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,8 @@ sub onRecordOperationDone()
285285
end sub
286286

287287
function onKeyEvent(key as string, press as boolean) as boolean
288+
289+
if m.top.getScene().disableRemote then return false
288290
if not press then return false
289291

290292
detailsGrp = m.top.findNode("detailsPane")

components/login/UserRow.bs

+2
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ sub setUser()
4747
end sub
4848

4949
function onKeyEvent(key as string, press as boolean) as boolean
50+
51+
if m.top.getScene().disableRemote then return false
5052
if not press then return false
5153

5254
return false

components/login/UserSelect.bs

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ sub redraw()
2525
end sub
2626

2727
function onKeyEvent(key as string, press as boolean) as boolean
28+
29+
if m.top.getScene().disableRemote then return false
2830
if not press then return false
2931

3032
if key = "back"

components/movies/MovieDetails.bs

+2
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,8 @@ end sub
347347

348348
function onKeyEvent(key as string, press as boolean) as boolean
349349

350+
if m.top.getScene().disableRemote then return false
351+
350352
' Due to the way the button pressed event works, need to catch the release for the button as the press is being sent
351353
' directly to the main loop. Will get this sorted in the layout update for Movie Details
352354
if key = "OK" and m.top.findNode("options-button").isInFocusChain()

components/movies/MovieOptions.bs

+2
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ end sub
9696

9797
function onKeyEvent(key as string, press as boolean) as boolean
9898

99+
if m.top.getScene().disableRemote then return false
100+
99101
if key = "down" or (key = "OK" and m.top.findNode("buttons").hasFocus())
100102
m.top.findNode("buttons").setFocus(false)
101103
m.menus[m.selectedItem].setFocus(true)

components/music/AlbumGrid.bs

+2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ function getData()
3737
end function
3838

3939
function onKeyEvent(key as string, press as boolean) as boolean
40+
41+
if m.top.getScene().disableRemote then return false
4042
if not press then return false
4143

4244
if key = "up"

components/music/AlbumView.bs

+3
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ sub setOnScreenTextValues(json)
9595
end sub
9696

9797
function onKeyEvent(key as string, press as boolean) as boolean
98+
99+
if m.top.getScene().disableRemote then return false
100+
98101
if not press then return false
99102

100103
if key = "options"

components/music/ArtistView.bs

+2
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,8 @@ end sub
252252

253253
function onKeyEvent(key as string, press as boolean) as boolean
254254

255+
if m.top.getScene().disableRemote then return false
256+
255257
if m.buttonGrp.isInFocusChain()
256258
if key = "OK"
257259
if press

components/music/AudioPlayerView.bs

+2
Original file line numberDiff line numberDiff line change
@@ -543,6 +543,8 @@ end sub
543543
' Process key press events
544544
function onKeyEvent(key as string, press as boolean) as boolean
545545

546+
if m.top.getScene().disableRemote then return false
547+
546548
' Key bindings for remote control buttons
547549
if press
548550
' If user presses key to turn off screensaver, don't do anything else with it

components/music/PlaylistView.bs

+2
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ sub setOnScreenTextValues(json)
9494
end sub
9595

9696
function onKeyEvent(key as string, press as boolean) as boolean
97+
98+
if m.top.getScene().disableRemote then return false
9799
if not press then return false
98100

99101
if key = "options"

components/options/OptionsSlider.bs

+2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ sub setFields()
2424
end sub
2525

2626
function onKeyEvent(key as string, press as boolean) as boolean
27+
28+
if m.top.getScene().disableRemote then return false
2729
if not press then return false
2830

2931
if key = "options" or key = "back"

components/photos/PhotoDetails.bs

+2
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ sub isRandomChanged()
110110
end sub
111111

112112
function onKeyEvent(key as string, press as boolean) as boolean
113+
114+
if m.top.getScene().disableRemote then return false
113115
if not press then return false
114116

115117
if key = "right"

components/quickConnect/QuickConnectDialog.bs

+3
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ sub onButtonSelected()
5959
end sub
6060

6161
function onKeyEvent(key as string, press as boolean) as boolean
62+
63+
if m.top.getScene().disableRemote then return false
64+
6265
if not press then return false
6366

6467
' Note that "OK" does not get sent here, hence onButtonSelected() above.

components/search/SearchResults.bs

+2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ end sub
5353

5454
function onKeyEvent(key as string, press as boolean) as boolean
5555

56+
if m.top.getScene().disableRemote then return false
57+
5658
m.searchAlphabox = m.top.findNode("search_Key")
5759
if m.searchAlphabox.textEditBox.hasFocus()
5860
m.searchAlphabox.textEditBox.translation = "[0, -150]"

components/settings/settings.bs

+2
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,8 @@ function isFormInFocus() as boolean
231231
end function
232232

233233
function onKeyEvent(key as string, press as boolean) as boolean
234+
235+
if m.top.getScene().disableRemote then return false
234236
if not press then return false
235237

236238
if (key = "back" or key = "left") and m.settingsMenu.focusedChild <> invalid and m.userLocation.Count() > 1

components/tvshows/TVEpisodeRow.bs

+2
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ function setData()
5656
end function
5757

5858
function onKeyEvent(key as string, press as boolean) as boolean
59+
60+
if m.top.getScene().disableRemote then return false
5961
if not press then return false
6062

6163
return false

components/tvshows/TVEpisodeRowWithOptions.bs

+2
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ sub videoOptionsClosed()
8181
end sub
8282

8383
function onKeyEvent(key as string, press as boolean) as boolean
84+
85+
if m.top.getScene().disableRemote then return false
8486
if not press then return false
8587

8688
if key = "options" and isValid(m.rows.focusedChild) and isValid(m.rows.focusedChild.rowItemFocused)

components/tvshows/TVEpisodes.bs

+3
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ end function
6868

6969
' Handle navigation input from the remote and act on it
7070
function onKeyEvent(key as string, press as boolean) as boolean
71+
72+
if m.top.getScene().disableRemote then return false
73+
7174
if key = "left" and m.tvEpisodeRow.hasFocus()
7275
m.shuffle.setFocus(true)
7376
return true

components/tvshows/TVListOptions.bs

+2
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ end sub
9898

9999
function onKeyEvent(key as string, press as boolean) as boolean
100100

101+
if m.top.getScene().disableRemote then return false
102+
101103
if key = "down" or (key = "OK" and m.top.findNode("buttons").hasFocus())
102104
m.top.findNode("buttons").setFocus(false)
103105
m.menus[m.selectedItem].setFocus(true)

components/tvshows/TVShowDetails.bs

+3
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ sub onShuffleEpisodeDataLoaded()
183183
end sub
184184

185185
function onKeyEvent(key as string, press as boolean) as boolean
186+
187+
if m.top.getScene().disableRemote then return false
188+
186189
if key = "OK" or key = "play"
187190
if m.Shuffle.hasFocus()
188191
m.getShuffleEpisodesTask.showID = m.top.itemContent.id

components/video/OSD.bs

+2
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ sub onButtonSelected()
139139
end sub
140140

141141
function onKeyEvent(key as string, press as boolean) as boolean
142+
143+
if m.top.getScene().disableRemote then return false
142144
if not press then return false
143145

144146
if key = "OK"

components/video/VideoPlayerView.bs

+2
Original file line numberDiff line numberDiff line change
@@ -581,6 +581,8 @@ end function
581581

582582
function onKeyEvent(key as string, press as boolean) as boolean
583583

584+
if m.top.getScene().disableRemote then return false
585+
584586
' Keypress handler while user is inside the chapter menu
585587
if m.chapterMenu.hasFocus()
586588
if not press then return false

0 commit comments

Comments
 (0)