Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove main thread XR #120

Open
asajeffrey opened this issue Jan 14, 2020 · 3 comments
Open

Remove main thread XR #120

asajeffrey opened this issue Jan 14, 2020 · 3 comments

Comments

@asajeffrey
Copy link
Member

If we can move most devices off the main thread, this just leaves glwindow on macos as being the only device with main thread affinity. We could refactor the code so that the main-thread code is in webxr/glwindow rather than webxr-api which would avoid the complexity on platforms which don't need it.

@asajeffrey
Copy link
Member Author

IRC chat with @jdm on why this might be A Good Thing: https://mozilla.logbot.info/servo/20200114#c16853695

@Manishearth
Copy link
Member

Oh, that's an interesting plan. So basically when we set up the discovery object we give it a handle to the main thread for the few cases where it needs one? That can work.

@asajeffrey
Copy link
Member Author

I think we could just rip out all the main-thread-specific code, and for devices that have main thread affinity, they can do the messaging themselves. The downside would be one more active thread for devices which have main thread affinity, but if that's just the glwindow test device then I'm not too worried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants