You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Method Gl::get_tex_parameter_iv when passed GL_TEXTURE_BORDER_COLOR will try to write four integer values in a &mut GLint which is obviously not large enough.
The same thing can happen with Gl::get_tex_parameter_fv.
For now, it can't happen with Gl::get_framebuffer_attachment_parameter_iv and Gl::get_renderbuffer_parameter_iv because all framebuffer attachment and renderbuffer parameters are single-valued, but nothing guarantees us that this will be true of all GL extensions in the future, so I would make it unsafe too.
Cc @kvark with whom I had debated about that in the past when it was a problem in gleam.
The text was updated successfully, but these errors were encountered:
Other methods that may need to be unsafe include Gl::get_query_iv, Gl::get_query_object_iv, Gl::get_query_object_uiv, Gl::get_query_object_i64v and Gl::get_query_object_ui64v.
Method
Gl::get_tex_parameter_iv
when passedGL_TEXTURE_BORDER_COLOR
will try to write four integer values in a&mut GLint
which is obviously not large enough.The same thing can happen with
Gl::get_tex_parameter_fv
.For now, it can't happen with
Gl::get_framebuffer_attachment_parameter_iv
andGl::get_renderbuffer_parameter_iv
because all framebuffer attachment and renderbuffer parameters are single-valued, but nothing guarantees us that this will be true of all GL extensions in the future, so I would make it unsafe too.Cc @kvark with whom I had debated about that in the past when it was a problem in
gleam
.The text was updated successfully, but these errors were encountered: