Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading instructions for 0.25 #407

Open
kornelski opened this issue Dec 19, 2019 · 5 comments
Open

Upgrading instructions for 0.25 #407

kornelski opened this issue Dec 19, 2019 · 5 comments

Comments

@kornelski
Copy link
Contributor

I can't find release notes. I can't find a changelog. I can't find what has changed in the API, so I'm struggling to update my code.

122 | use html5ever::rcdom::{Handle, RcDom};
| ^^^^^ could not find rcdom in html5ever

It seems like 0.25 has been a major change of the API, and RcDom has been dropped entirely, all of my code is incompatible, and I don't even know where to start fixing it.

@jdm
Copy link
Member

jdm commented Dec 19, 2019

The changes in 0.25 represent that RcDom was only ever intended as an internal API for tests and provides no guarantees around safety/correctness. If you wish to continue using it, the code is available at https://github.com/servo/html5ever/tree/master/rcdom.

@jdm
Copy link
Member

jdm commented Dec 19, 2019

Kuchiki's tree representation is a better supported tree type: https://github.com/kuchiki-rs/kuchiki/blob/master/src/tree.rs

@SimonSapin
Copy link
Member

better supported

Err I don’t know, nobody’s contributing to it at the moment.

@kornelski
Copy link
Contributor Author

kornelski commented Dec 19, 2019

Thanks for recommendations.

Kuchiki doesn't use the latest version of html5ever. The test rcdom crate has dropped support for serialization (which I also relied on), so I it seems that I won't be able to upgrade for now.

@jdm
Copy link
Member

jdm commented Dec 19, 2019

I have submitted kuchiki-rs/kuchiki#65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants