Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

retry does not work when treeclosed #139

Open
kennytm opened this issue Nov 9, 2017 · 0 comments
Open

retry does not work when treeclosed #139

kennytm opened this issue Nov 9, 2017 · 0 comments

Comments

@kennytm
Copy link

kennytm commented Nov 9, 2017

(Tried on rust-lang/rust's bors, not sure how updated is that)

Repro steps:

  1. Close the tree with treeclosed=1
  2. Let all pending PRs finish.
  3. Select a failed PR and give it p=2.
  4. Send a retry

Expected:

  • Homu should create a merge commit and move the PR to "pending" state

Actual:

  • The PR's state becomes "approved", but nothing else happens.

Note: The PR will start immediately after issuing a treeclosed-.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant