From cf7d6a5ca20b87d48e2f4acdf2aa5fd80aae8ca9 Mon Sep 17 00:00:00 2001 From: Adem Kouki Date: Sun, 8 Dec 2024 04:39:48 +0100 Subject: [PATCH 1/3] Fix scroll in selector popover Stopping the wheel event propagation on the PopoverContent resolves the issue. --- src/components/multi-select.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/components/multi-select.tsx b/src/components/multi-select.tsx index ee5eeca..43b3e37 100644 --- a/src/components/multi-select.tsx +++ b/src/components/multi-select.tsx @@ -188,6 +188,10 @@ export const MultiSelect = React.forwardRef< } }; + const stopWheelEventPropagation: React.WheelEventHandler = (e) => { + e.stopPropagation(); + }; + return ( setIsPopoverOpen(false)} + onWheel={stopWheelEventPropagation} > Date: Sun, 8 Dec 2024 04:44:37 +0100 Subject: [PATCH 2/3] Fix Touch Move in selector popover --- src/components/multi-select.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/components/multi-select.tsx b/src/components/multi-select.tsx index 43b3e37..eb65164 100644 --- a/src/components/multi-select.tsx +++ b/src/components/multi-select.tsx @@ -192,6 +192,10 @@ export const MultiSelect = React.forwardRef< e.stopPropagation(); }; + const stopTouchMoveEventPropagation: React.TouchEventHandler = (e) => { + e.stopPropagation(); + }; + return ( setIsPopoverOpen(false)} onWheel={stopWheelEventPropagation} + onTouchMove={stopTouchMoveEventPropagation} > Date: Sun, 8 Dec 2024 04:50:05 +0100 Subject: [PATCH 3/3] Update README.md --- README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/README.md b/README.md index 96a2b42..e959433 100644 --- a/README.md +++ b/README.md @@ -215,6 +215,14 @@ export const MultiSelect = React.forwardRef< } }; + const stopWheelEventPropagation: React.WheelEventHandler = (e) => { + e.stopPropagation(); + }; + + const stopTouchMoveEventPropagation: React.TouchEventHandler = (e) => { + e.stopPropagation(); + }; + return ( setIsPopoverOpen(false)} + onWheel={stopWheelEventPropagation} + onTouchMove={stopTouchMoveEventPropagation} >