Fixes Code 39 decoding where parts of the results are skipped. Relates to #41

Christoph Oberhofer · Christoph Oberhofer · commit 79356dcdbde6 · 2015-11-15T21:28:43.000+01:00
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 quaggaJS
 ========
 
-- [Changelog](#changelog) (2015-10-13)
+- [Changelog](#changelog) (2015-11-15)
 
 ## What is QuaggaJS?
 
@@ -434,6 +434,12 @@ on the ``singleChannel`` flag in the configuration when using ``decodeSingle``.
 
 ## <a name="changelog">Changelog</a>
 
+### 2015-11-15
+
+- Fixes
+  - Fixed inconsistency in Code 39 decoding
+  - added inline-source-map to quagga.js file
+
 ### 2015-10-13
 Take a look at the release-notes ([0.8.0]
 (https://github.com/serratus/quaggaJS/releases/tag/v0.8.0))
diff --git a/dist/quagga.js b/dist/quagga.js
diff --git a/dist/quagga.min.js b/dist/quagga.min.js
diff --git a/example/live_w_locator.html b/example/live_w_locator.html
@@ -94,7 +94,7 @@ <h3>The user's camera</h3>
         </p>
       </footer>
 
-    <script src="../src/vendor/jquery-1.9.0.min.js" type="text/javascript"></script>
+    <script src="vendor/jquery-1.9.0.min.js" type="text/javascript"></script>
     <script src="../dist/quagga.js" type="text/javascript"></script>
     <script src="live_w_locator.js" type="text/javascript"></script>
   </body>
diff --git a/lib/quagga.js b/lib/quagga.js
diff --git a/package.json b/package.json
@@ -9,7 +9,7 @@
     "babel-core": "^5.8.25",
     "babel-eslint": "^4.1.3",
     "babel-loader": "^5.3.2",
-    "chai": "^3.2.0",
+    "chai": "^1.10.0",
     "core-js": "^1.2.1",
     "grunt": "^0.4.5",
     "grunt-contrib-jshint": "^0.11.3",
@@ -30,6 +30,7 @@
     "karma-source-map-support": "^1.1.0",
     "karma-webpack": "^1.7.0",
     "mocha": "^2.3.2",
+    "phantomjs": "^1.9.18",
     "sinon": "^1.16.1",
     "webpack": "^1.12.2"
   },
diff --git a/plugins/umd.js b/plugins/umd.js
@@ -10,7 +10,6 @@ MyUmdPlugin.prototype.apply = function(compiler) {
     	var mainTemplate = compilation.mainTemplate;
     	compilation.templatesPlugin("render-with-entry", function(source, chunk, hash) {
 
-            var amdFactory = "factory";
     		return new ConcatSource(new OriginalSource(
     			"(function webpackUniversalModuleDefinition(root, factory) {\n" +
     			"	if(typeof exports === 'object' && typeof module === 'object')\n" +
diff --git a/src/code_39_reader.js b/src/code_39_reader.js
@@ -116,6 +116,7 @@ Code39Reader.prototype._patternToChar = function(pattern) {
             return String.fromCharCode(self.ALPHABET[i]);
         }
     }
+    return -1;
 };
 
 Code39Reader.prototype._findNextWidth = function(counters, current) {
diff --git a/webpack.config.js b/webpack.config.js
@@ -6,7 +6,7 @@ module.exports = {
     entry: [
         './src/quagga.js'
     ],
-    devtool: 'source-map',
+    devtool: 'inline-source-map',
     module: {
         loaders: [{
             test: /\.jsx?$/,
@@ -24,8 +24,7 @@ module.exports = {
     output: {
         path: __dirname + '/dist',
         publicPath: '/',
-        filename: 'quagga.js',
-        sourceMapFilename: 'quagga.map'
+        filename: 'quagga.js'
     },
     devServer: {
         contentBase: './',

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ Code39Reader.prototype._patternToChar = function(pattern) {`
`116`	`116`	`return String.fromCharCode(self.ALPHABET[i]);`
`117`	`117`	`}`
`118`	`118`	`}`
	`119`	`+ return -1;`
`119`	`120`	`};`
`120`	`121`
`121`	`122`	`Code39Reader.prototype._findNextWidth = function(counters, current) {`