Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Sermant support Prometheus monitoring? #1445

Closed
zwmagic opened this issue Feb 6, 2024 · 3 comments · Fixed by #1598
Closed

Can Sermant support Prometheus monitoring? #1445

zwmagic opened this issue Feb 6, 2024 · 3 comments · Fixed by #1598
Assignees
Labels
area/framework Issues or PRs releated to sermant core service kind/feature Issue for new feature
Milestone

Comments

@zwmagic
Copy link
Collaborator

zwmagic commented Feb 6, 2024

What would you like to be added?

It is hoped that Sermant will support Prometheus monitoring so that Sermant's core metrics as well as each plugin's custom metrics can be monitored through Grafana.

Why is this needed?

  1. Through integration with Grafana, we can use its rich data visualization capabilities to create intuitive dashboards that can help us quickly locate and solve problems.
  2. Through monitoring metrics, monitoring alarms can be added to ensure the stability of sermant.

###Proposal proposal
Regarding the need for Sermant to support Prometheus monitoring, I am currently considering the following three options and hope to discuss them in the community in order to choose the most suitable one or combine it with other more suitable options.

Solution 1: Integrate Micrometer

Advantages: Micrometer provides a common interface integrated with a variety of monitoring systems (including Prometheus), has complete documentation, and is easy to get started.
Disadvantages: need to introduce additional dependencies

Option 2: Use Prometheus’ native API directly

Advantages: Directly use Prometheus native capabilities
Disadvantages: Completely bound to Prometheus

Option 3: Implement custom Metric interface

advantage:

  • Provides a flexible and scalable way to customize metrics, easy to implement and maintain
  • Compatible with a variety of surveillance systems

shortcoming:

  • Additional code needs to be developed to handle indicator registration and exposure
  • It may take time for the community to adapt to this new interface
@zwmagic zwmagic added the kind/feature Issue for new feature label Feb 6, 2024
@hanbingleixue hanbingleixue added the area/plugin Issues or PRs releated to sermant plugin service label Feb 6, 2024
@hanbingleixue
Copy link
Collaborator

hanbingleixue commented Feb 6, 2024

Currently, the monitoring plug-in supports reporting metrics to Prometheus. The monitoring plugin also supports reporting the metrics information collected by the flow control plugin. You can check the user manual of the monitoring plug-in to see if it meets your requirements. Monitoring plugin manual address: https://sermant.io/zh/document/plugin/monitor.html.

@hanbingleixue hanbingleixue self-assigned this Feb 6, 2024
@zwmagic
Copy link
Collaborator Author

zwmagic commented Feb 6, 2024

Prometheus metrics capabilities can be transferred to core, so that other plugins can also customize metrics.

@lilai23 lilai23 added area/framework Issues or PRs releated to sermant core service and removed area/plugin Issues or PRs releated to sermant plugin service labels Mar 8, 2024
@daizhenyu
Copy link
Collaborator

daizhenyu commented Mar 13, 2024

The Sermant community accepted this issue request and will support Prometheus in monitoring the metrics information of the Sermant framework, plugins, and host microservices in the future.

@kkf1 kkf1 changed the title Sermant 能够支持 Prometheus 监控 Can Sermant support Prometheus monitoring? Apr 13, 2024
@zwmagic zwmagic mentioned this issue Aug 17, 2024
3 tasks
@lilai23 lilai23 added this to the v2.1.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service kind/feature Issue for new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants