Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog does not mention what the breaking change is #113

Closed
2 of 9 tasks
joukevandermaas opened this issue Jul 13, 2021 · 4 comments
Closed
2 of 9 tasks

Changelog does not mention what the breaking change is #113

joukevandermaas opened this issue Jul 13, 2021 · 4 comments

Comments

@joukevandermaas
Copy link

A few questions before you begin:

Is this an issue related to the Serilog core project or one of the sinks or community projects. This issue list is intended for Serilog core issues. If this issue relates to a sink or related project, please log on the related repository. Please use Gitter chat and Stack Overflow for discussions and questons.

This is about serilog-sinks-console (this repo).

Does this issue relate to a new feature or an existing bug?

  • Bug
  • New Feature
  • Changelog

What version of Serilog Console Sink is affected by this issue? Please list the related NuGet package.

4.0.0: https://github.com/serilog/serilog-sinks-console/releases/tag/v4.0.0

What is the target framework and operating system affected by this issue? Please see target frameworks & net standard matrix.

  • netCore 2.0
  • netCore 1.0
  • 4.7
  • 4.6.x
  • 4.5.x
  • N/A

Please describe the current behaviour you are experiencing?

When upgrading a package, especially when there is a major version bump, I look at the changelog to see what the breaking change was so I can know what I need to do to upgrade. The changelog for 4.0.0 is just a bunch of PR references. I've looked through them but I can't really see what would break just from that, especially since they're just links with no additional text.

Please describe the expected behaviour if the ?

A small line describing the breaking change would be much appreciated. I understand time is short so it doesn't have to be a lot, just enough to indicate what I should look out for when upgrading.

@nblumhardt
Copy link
Member

Fixed -

Thanks! 👍

@nblumhardt
Copy link
Member

(In https://github.com/serilog/serilog-sinks-console/releases/tag/v4.0.0 ... unfortunately, GitHub doesn't expand issue/PR references to their full titles in release descriptions, so still some work to do rewriting the release notes there, too :-/ )

@joukevandermaas
Copy link
Author

Thank you very much! I appreciate the quick response.

@erichiller
Copy link

About the syncRoot addition... Is there a way to configure this using ConfigurationBuilder and .ReadFrom.Configuration( ) on LoggerConfiguration ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants