Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationReader.FindConfigurationExtensionMethods relies on one specific implementation of ExtensionAttribute #306

Closed
sajagi opened this issue Apr 7, 2022 · 1 comment
Closed

ConfigurationReader.FindConfigurationExtensionMethods relies on one specific implementation of ExtensionAttribute #306

sajagi opened this issue Apr 7, 2022 · 1 comment
Labels
bug

Comments

@sajagi
Copy link
Contributor

sajagi commented Apr 7, 2022 •
edited
Loading

The method (ConfigurationReader.FindConfigurationExtensionMethods) should not rely on specific ExtensionAttribute type present in System.Runtime.dll, but rather on any type with matching name.

The attribute can be polyfilled in any assembly to enable extension method support.

In one (my) case this attribute is implemented in nunit.engine.core assembly which leads Serilog to not recognize extension methods when running tests using e.g. nunit3-console.

Happy to provide a PR.
@nblumhardt nblumhardt added the bug label Apr 7, 2022
@nblumhardt
Copy link
Member

PR would be great, thanks. We should be able to squeeze this into #299.

@sajagi sajagi mentioned this issue Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sajagi @nblumhardt @skomis-mm