chore: reset info.serialNumber when resetting mock ports #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE Resetting the value in the phony port's `info.serialNumber` property when `BindingMock.reset()` is called will make its behavior "more deterministic." This is useful when doing deep-equality checks against a `BindingMock` instance (or more specifically, a `SerialPort` instance containing a `BindingMock` instance); judicious use of `BindingMock.reset()` will mean a developer can expect the value of `info.serialNumber` to be deterministic when tests are run in any order or in isolation. People have a tendency to code their way around stuff like this, so this is _potentially_ a breaking change for _somebody somewhere._
|
If you hate this, you can still keep the test coverage. 😉 |
reconbot
approved these changes
Jul 10, 2019
|
I'm ok with these tests but it should be noted the bindings tests cover the mock bindings as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Resetting the value in the phony port's
info.serialNumberpropertywhen
BindingMock.reset()is called will make its behavior "moredeterministic." This is useful when doing deep-equality checks against a
BindingMockinstance (or more specifically, aSerialPortinstancecontaining a
BindingMockinstance); judicious use ofBindingMock.reset()will mean a developer can expect the value ofinfo.serialNumberto be deterministic when tests are run in any orderor in isolation.
People have a tendency to code their way around stuff like this, so this
is potentially a breaking change for somebody somewhere.