Updates for Node v12 #1743
Merged
Updates for Node v12 #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
approved these changes
Dec 15, 2018
|
Fixing the warning for Windows is also welcome, I know we do some probably safe casting of ints to file handles (or the other way around?) but if it can be safer I'm for it. |
|
@HipsterBrown if you're available tonight to help test I can work with you |
|
looks good 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is everything.
The deprecation warnings about
v8::StringObject::Neware pending a new release of Nan and there's nothing to do in this module itself (nodejs/nan@509859c#commitcomment-31470115).(BTW you have a ton of C4312, C4302 and C4311 conversion warnings with MSVC. I can fix those or at least silence the warning if you want in another PR.)
Fixes #1742