Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy decorator import error #10

Open
gretzteam opened this issue Sep 8, 2020 · 2 comments
Open

numpy decorator import error #10

gretzteam opened this issue Sep 8, 2020 · 2 comments
Assignees
Labels

Comments

@gretzteam
Copy link

Using Python 3.8 on Ubuntu 20.04, getting the following import error:

File "/PyDSM/pydsm/NTFdesign/tests/test_NTFdesign_hybrid.py", line 27, in
from numpy.testing import decorators as dec
ImportError: cannot import name 'decorators' from 'numpy.testing' (/home/python3.8/site-packages/numpy/testing/init.py)

I fixed it by adding ._private to the numpy.testing module:
from numpy.testing._private import decorators as dec

@callegar
Copy link
Contributor

callegar commented Sep 8, 2020

Thanks for the report. I'll need to look into it since _private stuff is probably not meant for use out of numpy. Unfortunately, this year has managed breaking many activities and I may not have much time for PyDSM for about 1 month. In the meantime, I believe that your quick hack can be a workable solution.

@sergiocallegari sergiocallegari self-assigned this Sep 8, 2020
@sergiocallegari
Copy link
Owner

Thanks for the interest in the software and the ideas being implemented! If you have questions on specific theoretical aspects, rather than possible bugs, it may be good to move the discussion elsewhere, though to avoid being too distracting to those coming in just for the issue about the decorator.

May I suggest that either:

  • you contact me on my email address; or (possibly even better)
  • you open a new issue for the package documentation, so we can see if the latter can be improved to clarify any doubt that one may have about the algorithms that are implemented in the code?

If you prefer I can copy over your question to a new issue myself and answer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants