Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver does not follow library way #1

Open
ttlappalainen opened this issue Jan 4, 2024 · 2 comments
Open

Driver does not follow library way #1

ttlappalainen opened this issue Jan 4, 2024 · 2 comments

Comments

@ttlappalainen
Copy link

I was looking for driver for new ESP32 devices. Yours is one alternative, but its use differs the way designed for N2k library.

In constructor you have queue sizes. Library calls InitCANFrameBuffers(); before opening driver. User can set frame buffers with SetN2kCANSendFrameBufSize and SetN2kCANReceiveFrameBufSize. Different drivers then should initialize frame buffers on InitCANFrameBuffers. If driver supports interrupted queues, it is best that driver initiates driver queues by using defined sizes (leave 4 frames for driver tx buffer). Also if driver supports multiple mailboxes (like Teensies), it should split given Tx framebuffer to priority buffers.

@sergei
Copy link
Owner

sergei commented Jan 9, 2024

Well, I written this driver when I knew nothing about N2K and even less about ESP32 :-) Once I finished the https://github.com/sergei/sci2000 my focus has shifted, so I don't plan to make any further changes in foreseeable future. I still would keep an eye on your NMEA2000 project. Thanks a lot for great contribution to the sailing community!

@ttlappalainen
Copy link
Author

OK. Then I may use NMEA2000_esp32xx as base and develop that and may take some ideas (CtrlTask) from yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants