Skip to content

Get rid of redundant status argument in Http::wind #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

Get rid of redundant status argument in Http::wind #3049

merged 2 commits into from
Nov 18, 2024

Conversation

@GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Nov 18, 2024

Turns out this was always being passed 204, except one case where it should have been deserialising the Member return type anyway. This fixes both issues.

@github-actions github-actions bot added model Related to the `model` module. http Related to the `http` module. labels Nov 18, 2024
@arqunis arqunis added enhancement An improvement to Serenity. fix A solution to an existing bug. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Nov 18, 2024
arqunis
arqunis reviewed Nov 18, 2024
View reviewed changes
@GnomedDev GnomedDev force-pushed the remove-wind-expected-param branch from 41ec61b to 8995b8f Compare November 18, 2024 20:05
@GnomedDev GnomedDev merged commit 099315f into serenity-rs:next Nov 18, 2024
21 checks passed
@GnomedDev GnomedDev deleted the remove-wind-expected-param branch November 18, 2024 20:11
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
b93c1b5 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
67f5b6a 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
0431fba 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 14, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
503862c 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 5, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
93a5e95 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 5, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
4ba2876 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 7, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
a8e3bb8 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 10, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
d1eecb9 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Mar 11, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
523ad20 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 26, 2025
@GnomedDev
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
3c18733 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
GnomedDev added a commit that referenced this pull request Apr 28, 2025
@GnomedDev
Get rid of redundant status argument in Http::wind (#3049)
0599bf4 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
GnomedDev added a commit that referenced this pull request May 19, 2025
@GnomedDev
Get rid of redundant status argument in Http::wind (#3049)
51dee21 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
6c750ca 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
f285f00 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
5d63330 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
849b7fa 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
ef5cb3f 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
c399b03 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
c622fb4 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@GnomedDev @mkrasnitski
Get rid of redundant status argument in Http::wind (serenity-rs#3049)
8a80651 
Turns out this was always being passed 204, except one case where it
should have been deserialising the `Member` return type anyway. This
fixes both issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arqunis arqunis arqunis approved these changes

Assignees

No one assigned

Labels

breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. fix A solution to an existing bug. http Related to the `http` module. model Related to the `model` module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GnomedDev @arqunis