Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2400 #2486

Closed
wants to merge 1 commit into from
Closed

Conversation

mkrasnitski
Copy link
Collaborator

It was determined that #2400 broke shard restarts and caused them to not be initiated when a network error occurred, leading to crashes because of uncaught errors. As a hotfix, this reverts that PR.

@github-actions github-actions bot added gateway Related to the `gateway` module. examples Related to Serenity's examples. labels Jul 6, 2023
@arqunis
Copy link
Member

arqunis commented Jul 6, 2023

@arqunis arqunis closed this Jul 6, 2023
@arqunis arqunis added the fix A solution to an existing bug. label Jul 6, 2023
@mkrasnitski mkrasnitski deleted the gateway-revert branch July 19, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to Serenity's examples. fix A solution to an existing bug. gateway Related to the `gateway` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants