Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown is broken on next branch #2507

Closed
scottbot95 opened this issue Aug 12, 2023 · 2 comments
Closed

Shutdown is broken on next branch #2507

scottbot95 opened this issue Aug 12, 2023 · 2 comments
Labels
bug Something misbehaves or is not working. gateway Related to the `gateway` module.

Comments

@scottbot95
Copy link

Since the revert of #2400 in #2486, it is impossible to shutdown a serenity bot without killing the process. Calling ShardManager.shutdown_all() will hang forever and results in the following warning being logged:

WARN shutdown_all:shutdown{shard_id=ShardId(0) code=1000}: serenity::gateway::bridge::shard_manager: 287: Failed to cleanly shutdown shard 0, reached timeout: Elapsed(())
@arqunis arqunis added bug Something misbehaves or is not working. gateway Related to the `gateway` module. labels Aug 13, 2023
fenhl added a commit to fenhl/serenity-utils that referenced this issue Aug 25, 2023
@fenhl
Immediately return from run on shutdown
456eb8d 
Workaround for serenity-rs/serenity#2507.
@tazz4843
Copy link
Contributor

See #2523 as a possible fix

@tazz4843 tazz4843 mentioned this issue Aug 27, 2023
Merged
@kangalio
Copy link
Collaborator

#2523 confirmed stable by @tazz4843

image

fenhl added a commit to fenhl/serenity-utils that referenced this issue Aug 30, 2023
@fenhl
Revert "Immediately return from run on shutdown"
0fedace 
This was a workaround for
serenity-rs/serenity#2507 which is now fixed.

This reverts commit 456eb8d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something misbehaves or is not working. gateway Related to the `gateway` module.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@scottbot95 @arqunis @kangalio @tazz4843