Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use proc_macro_derive attributes #614

Closed
dtolnay opened this issue Nov 9, 2016 · 3 comments
Closed

Update to use proc_macro_derive attributes #614

dtolnay opened this issue Nov 9, 2016 · 3 comments
Assignees
@dtolnay
Labels
derive

Comments

@dtolnay
Copy link
Member

dtolnay commented Nov 9, 2016

rust-lang/rust#37614 introduces #[proc_macro_derive(Serialize, attributes(serde))] to whitelist attributes of a certain name inside structs that have a custom derive. We no longer need to strip serde attributes after expansion.

Also that change requires custom derives to no longer return a copy of the input item so we need to fix that.
@dtolnay dtolnay added the derive label Nov 9, 2016
@dtolnay dtolnay self-assigned this Nov 9, 2016
@dtolnay dtolnay mentioned this issue Nov 10, 2016
Closed
53 tasks
@KodrAus KodrAus mentioned this issue Nov 10, 2016
Closed
@dtolnay
Copy link
Member Author

dtolnay commented Nov 16, 2016

Fixed in #618 but currently blocked by rust-lang/rust#37788.

@lambda-fairy lambda-fairy mentioned this issue Nov 16, 2016
Closed
@antoyo
Copy link

antoyo commented Nov 19, 2016

The bug you mentioned is fixed.
Could you please update a new version on crates.io?

@dtolnay
Copy link
Member Author

dtolnay commented Nov 19, 2016

Published as 0.8.18.

@dtolnay dtolnay closed this as completed Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtolnay dtolnay

Labels
derive
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoyo @dtolnay