-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolver
in Cargo.toml
changed MSRV
#2603
Comments
Thanks, I didn't realize Cargo would propagate that field from the workspace manifest into serde's manifest during publish. I don't understand why it does that — the choice of resolver is controlled by the top-level crate/workspace being built; serde as a dependency has no say in this. I'll revert that change. |
We propagate the resolver version so that |
I'd prefer if it did not do that for packages not containing any bin crates. |
At this time, the code responsible does not have that knowledge. However, I've been wanting to change our publish code to to explicitly list all auto targets at which point it would be possible to determine that. There still might be enough nuance to be annoying because examples are considered installable. |
As an easier fix that still eliminates resolver-related breakage for libraries, could we make sure Cargo disregards any value of I tried editing $CARGO_HOME/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.188/Cargo.toml to add error: failed to download `serde v1.0.188`
Caused by:
unable to get packages from source
Caused by:
failed to download replaced source registry `crates-io`
Caused by:
failed to parse manifest at `$CARGO_HOME/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.188/Cargo.toml`
Caused by:
`resolver` setting `100` is not valid, valid options are "1" or "2" |
More an FYI than a bug, I think, but #2602 said the following, which doesn't appear true for us:
For our CI, building serde on rustc 1.48 and 1.49 now fails with:
The text was updated successfully, but these errors were encountered: