From d208762c81883a181e8c6a9ca3f303e040105c7d Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Fri, 2 Sep 2022 20:50:24 -0700 Subject: [PATCH] Command-line ignore let_underscore_drop clippy lint For whatever reason, the #![cfg_attr(feature = "cargo-clippy", allow(let_underscore_drop))] attributes already in the code stopped working in the most recent nightly (2022-09-03). Likely in connection with https://github.com/rust-lang/rust/pull/97739 ? error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:958:13 | 958 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = note: `-D clippy::let-underscore-drop` implied by `-D clippy::pedantic` = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:992:13 | 992 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1616:9 | 1616 | let _ = deserializer; | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1640:9 | 1640 | let _ = deserializer; | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1651:9 | 1651 | let _ = seq; | ^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1662:9 | 1662 | let _ = map; | ^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1673:9 | 1673 | let _ = data; | ^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/private/de.rs:1440:13 | 1440 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/private/de.rs:2163:13 | 2163 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d61f75d6c..2dda35926 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -167,11 +167,11 @@ jobs: steps: - uses: actions/checkout@v3 - uses: dtolnay/rust-toolchain@clippy - - run: cd serde && cargo clippy --features rc,unstable -- -Dclippy::all -Dclippy::pedantic + - run: cd serde && cargo clippy --features rc,unstable -- -Dclippy::all -Dclippy::pedantic -Aclippy::let_underscore_drop - run: cd serde_derive && cargo clippy -- -Dclippy::all -Dclippy::pedantic - run: cd serde_derive_internals && cargo clippy -- -Dclippy::all -Dclippy::pedantic - - run: cd serde_test && cargo clippy -- -Dclippy::all -Dclippy::pedantic - - run: cd test_suite && cargo clippy --tests --features unstable -- -Dclippy::all -Dclippy::pedantic + - run: cd serde_test && cargo clippy -- -Dclippy::all -Dclippy::pedantic -Aclippy::let_underscore_drop + - run: cd test_suite && cargo clippy --tests --features unstable -- -Dclippy::all -Dclippy::pedantic -Aclippy::let_underscore_drop - run: cd test_suite/no_std && cargo clippy -- -Dclippy::all -Dclippy::pedantic miri: