Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extern crate warnings in test suite #351

Closed
dtolnay opened this issue Aug 28, 2017 · 1 comment
Closed

Extern crate warnings in test suite #351

dtolnay opened this issue Aug 28, 2017 · 1 comment
Labels

Comments

@dtolnay
Copy link
Member

dtolnay commented Aug 28, 2017

As of rustc 1.21.0-nightly (e26688824 2017-08-27), cargo test gives the following warnings.

   Compiling serde_json v1.0.2
warning: unused extern crate
   --> src/lib.rs:323:1
    |
323 | extern crate core;
    | ^^^^^^^^^^^^^^^^^^
    |
    = note: #[warn(unused_extern_crates)] on by default

warning: unused extern crate
  --> tests/stream.rs:11:1
   |
11 | extern crate serde;
   | ^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_extern_crates)] on by default
@dtolnay
Copy link
Member Author

dtolnay commented Mar 28, 2018

The extern crate core is no longer present, and the extern crate serde was fixed by rust-lang/rust#44825.

@dtolnay dtolnay closed this as completed Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant