test: skip test-child-process-stdio-reuse-readable-stdio on

It is flaky due to the same cause of test-child-process-pipe-dataflow being flaky - cygwin quirks - so skip it on Windows too. Drive-by: remove the skip mark of test-child-process-pipe-dataflow in the status file and directly skip it in the test with a comment. PR-URL: nodejs/node#49621 Backport-PR-URL: nodejs/node#51132 Co-authored-by: Artur Yapparov <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
sercher · Apr 25, 2024 · 8104f02 · 8104f02
1 parent ecf3055
commit 8104f02
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/graal-nodejs/test/parallel/parallel.status b/graal-nodejs/test/parallel/parallel.status
@@ -259,9 +259,6 @@ test-tls-passphrase: FAIL
 test-crypto-keygen: PASS,FLAKY
 # https://github.com/nodejs/node/issues/41201
 test-fs-rmdir-recursive: PASS, FLAKY
-# https://github.com/nodejs/node/issues/48300
-test-child-process-pipe-dataflow: PASS, FLAKY
-test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY
 # https://github.com/nodejs/node/issues/49985
 test-runner-watch-mode: PASS, FLAKY
 # https://github.com/nodejs/node/issues/50295

diff --git a/graal-nodejs/test/parallel/test-child-process-pipe-dataflow.js b/graal-nodejs/test/parallel/test-child-process-pipe-dataflow.js
@@ -1,5 +1,11 @@
 'use strict';
 const common = require('../common');
+
+if (common.isWindows) {
+  // https://github.com/nodejs/node/issues/48300
+  common.skip('Does not work with cygwin quirks on Windows');
+}
+
 const assert = require('assert');
 const path = require('path');
 const fs = require('fs');

diff --git a/graal-nodejs/test/parallel/test-child-process-stdio-reuse-readable-stdio.js b/graal-nodejs/test/parallel/test-child-process-stdio-reuse-readable-stdio.js
@@ -1,5 +1,11 @@
 'use strict';
 const common = require('../common');
+
+if (common.isWindows) {
+  // https://github.com/nodejs/node/issues/48300
+  common.skip('Does not work with cygwin quirks on Windows');
+}
+
 const assert = require('assert');
 const { spawn } = require('child_process');