Skip to content

Commit 4a03486

Browse files
committed
bootstrap: include event_target into the built-in snapshot
Since the module has to be loaded during bootstrap anyway. PR-URL: nodejs/node#45849 Backport-PR-URL: nodejs/node#46425 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
1 parent 3b3befe commit 4a03486

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

graal-nodejs/lib/internal/bootstrap/browser.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@ defineOperation(globalThis, 'setTimeout', timers.setTimeout);
4242
exposeLazyInterfaces(globalThis, 'internal/abort_controller', [
4343
'AbortController', 'AbortSignal',
4444
]);
45-
exposeLazyInterfaces(globalThis, 'internal/event_target', [
46-
'EventTarget', 'Event',
47-
]);
45+
const {
46+
EventTarget, Event,
47+
} = require('internal/event_target');
48+
exposeInterface(globalThis, 'Event', Event);
49+
exposeInterface(globalThis, 'EventTarget', EventTarget);
4850
exposeLazyInterfaces(globalThis, 'internal/worker/io', [
4951
'MessageChannel', 'MessagePort', 'MessageEvent',
5052
]);

graal-nodejs/test/parallel/test-bootstrap-modules.js

+3
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ const expectedModules = new Set([
4646
'NativeModule internal/constants',
4747
'NativeModule internal/dns/utils',
4848
'NativeModule internal/errors',
49+
'NativeModule internal/event_target',
4950
'NativeModule internal/fixed_queue',
5051
'NativeModule internal/fs/utils',
5152
'NativeModule internal/graal/buffer',
@@ -91,6 +92,7 @@ const expectedModules = new Set([
9192
'NativeModule internal/vm',
9293
'NativeModule internal/vm/module',
9394
'NativeModule internal/wasm_web_api',
95+
'NativeModule internal/webidl',
9496
'NativeModule internal/worker/js_transferable',
9597
'Internal Binding blob',
9698
'NativeModule async_hooks',
@@ -100,6 +102,7 @@ const expectedModules = new Set([
100102
'NativeModule url',
101103
'NativeModule internal/v8/startup_snapshot',
102104
'NativeModule vm',
105+
'NativeModule util',
103106
]);
104107

105108
if (!common.isMainThread) {

0 commit comments

Comments
 (0)