ON DELETE constraint should default to CASCADE if foreignKey has allowNull: false

[mickhansen]

var Foo = this.sequelize.define('Foo', { 
  bar_id: { type: Sequelize.INTEGER, allowNull: false }
});
var Bar = this.sequelize.define('Bar', {});

Foo.belongsTo(Bar, { foreignKey: 'bar_id'});

return Bar.sync({force: true}).then(function () {
  return Foo.sync({force: true});
});

Will fail on MySQL (haven't tested others so far) because the cascade defaults to SET NULL which "obviously" (took me a while to figure it out) obviously doesn't work well with a field that can't be NULL'ed.

Sequelize should check the foreignkey attribute definition, and if allowNull is false it should perhaps either use CASCADE by default or turn off constraints.

[EToreo]

A big +1 to this. This also took me a half day to figure out.

I might also be nice to have more options available to sync so that clients can turn the CASCADE and/or constraints off even when allowNull is set to true.

[mvallerie]

+1.

[phuvo]

I'm using Sequelize 3.13 with PostgreSQL 9.4

var Foo = sequelize.define('Foo', {});
var Bar = sequelize.define('Bar', {});
Bar.belongsTo(Foo, {
    foreignKey: { allowNull: false },
});

but FooId doesn't have ON DELETE CASCADE.

[igordeoliveirasa]

mine is not working yet...

[Mageek627]

@phuvo It's because you use belongsTo instead of hasOne/hasMany. They seem to have different behaviors with the ON DELETE constraint. See the description of this PR: #4506