Skip to content

Type hints on DeepDiff constructor are wrong #521

@DominicOram

Description

@DominicOram

Describe the bug
The type hints on:

  • exclude_paths
  • include_paths

Both imply that the argument is not optional but they are then given the default of =None, meaning that they are optional.

For our project previous versions of pyright were not picking this up but the latest (1.1.395) does pick it up.

To Reproduce
Run a pyright version 1.1.395 on the following:

DeepDiff({}, {})

and see that there is a type error.

Expected behavior
Above causes no type error

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions