feat(ui): finalize rehearsal console redesign#177
Merged
Conversation
Give the desktop workspace a rehearsal-first cockpit while tightening section timing and URL/project boundaries across the app stack.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sections[].timeRangeas a strict shared contract across TypeScript, Python, and Rust, including fail-closed legacy project validation.Test Plan
npm run test --workspace @bandscope/desktop -- App.test.tsx lib/analysis.test.ts lib/export.test.tsnpm run test --workspace @bandscope/shared-types -- index.test.tsuv run pytest tests/test_api.py -qfromservices/analysis-engineuv run ruff check src testsfromservices/analysis-enginecargo test --manifest-path apps/desktop/src-tauri/Cargo.toml --locked && cargo check --manifest-path apps/desktop/src-tauri/Cargo.toml --lockednpm audit --workspaces --audit-level=highBANDSCOPE_ENABLE_RUST_CHECK=1 ./scripts/harness/quickcheck.shhttp://127.0.0.1:5173: imported supported YouTube URL, started analysis, verifiedRehearsal Console,verse · 0:10–0:30, and stem-lane pending copy; current-session console errors: none.Security Notes
vparams are rejected before IPC, legacy project sections withouttimeRangefail closed,timeRangevalues are bounded to the Rustu32contract, and UI copy avoids presenting unavailable analysis as fact.PR continuity
feature/issue-106-stem-separation) and is not reused.mainbecause this branch was cut from the current release line;origin/develop...HEADincludes unrelated backlog/release divergence whileorigin/main...HEADis the intended focused 13-file diff.