Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle short sentences #2

Closed
seominjoon opened this issue Feb 27, 2019 · 8 comments
Closed

Handle short sentences #2

seominjoon opened this issue Feb 27, 2019 · 8 comments
Assignees

Comments

@seominjoon
Copy link
Owner

No description provided.

@jhyuklee
Copy link
Collaborator

jhyuklee commented Mar 3, 2019

Partially resolved using concatenation.

@raman-r-4978
Copy link

Hi @jhyuklee May I know what do you mean by concatenation? Is it a text concatenation or vector concatenation?

Please refer #13 for more details

@jhyuklee
Copy link
Collaborator

Hi @ramanrajarathinam. We concatenated short sentences into a single paragraph (an input to BERT), then performed the indexing. This resolved the short sentence issues.

@raman-r-4978
Copy link

Oh okay.. But may I know why model is not performing as expected when the input text is short?

@jhyuklee
Copy link
Collaborator

That's because the model was trained on SQuAD which usually contains a passage longer than a sentence.

@raman-r-4978
Copy link

So the only solution is to concatenate different texts? or Is there any other way to solve this?

@raman-r-4978
Copy link

raman-r-4978 commented Jan 31, 2020

Can you also please comment on this issues #9 and #13?

@jhyuklee
Copy link
Collaborator

So the only solution is to concatenate different texts? or Is there any other way to solve this?
=> For now, yes but I guess there can be plenty of other solutions that can de-bias the length bias like augmenting short passage QA training pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants