Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-aggregate.rb options don't work with named aggregates #19

Open
ttarczynski opened this issue Nov 10, 2016 · 1 comment
Open

check-aggregate.rb options don't work with named aggregates #19

ttarczynski opened this issue Nov 10, 2016 · 1 comment

Comments

@ttarczynski
Copy link

When using this with sensu => 0.24.0 (which introduced named aggregates) some options of check-aggregate.rb don't work any more. I think the following options are now broken:

  • --limit
  • --summarize
  • --output
  • --pattern
  • --honor-stash

I've tried to fix --output but after looking into the code I've found out that Sensu Aggregates (2.0) API is rewritten from scratch:

I think it makes sense to drop sensu < 0.24 compatibility and provide only options that can work with sensu => 0.24

@ttarczynski ttarczynski changed the title check-aggregate.rb options doesn't work with named aggregates check-aggregate.rb options don't work with named aggregates Nov 10, 2016
@majormoses
Copy link
Member

At this point we need to get this fixed even if it is a breaking change. As long as we properly call it out in the changelog and the maintainers version it as a major release I am 👍 on dropping the older support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants