bad URI with complex passwords

[ecozijnss]

when parsing complex passwords most plugins return bad URI while curl -v gets the content without a probelm.
the problem part in the password is:
Check failed to run: bad URI(is not URI?): http://admin:4L#*!1@logging-rabbitmq-0***.***.com:15672/api/queues/

[monkey670]

This looks like its related to an open PR with the underlying carrot-top function https://github.com/portertech/carrot-top/pull/8. Unfortunately the project looks to have gone stale. Maybe we could CGI.escape(password) the string before we pass it to the carrot-top functionality.

[matthewbretten]

That won't work because carrot-top parses the URI and would use the URL-encoded password as a parameter for Basic Auth, which then leads to a 401 as the password isn't correct and needs to be unescaped.
You can see this here:
https://github.com/portertech/carrot-top/blob/master/lib/carrot-top.rb#L48

So this issue requires carrot-top to be updated or for this plugin to use something else, preferably the latter given the lack of updates to carrot-top.

[Otoru]

Checking the project, I saw that the carrot-top hasn't received updates since 2012. Bearing that in mind, would it be valid to apply a cleaning of the uri parameters right here?
I thought about trying something like this and submitting a PR in this repository, but I would like to know if it is something valid.