Allow querying specific node for check-rabbitmq-node-health #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Infraded Thanks for the contribution and sorry for not getting to it sooner. Can you fixup the tests and give me a testing artifact? while I would prefer a unit or integration test I would accept anything that demonstrates input and output. Just running the commands and capturing that here, linking a gist, or even a screenshot. |
majormoses
requested changes
Aug 5, 2017
| node_prefix = config[:node_prefix] | ||
|
|
||
| # Determine node hostname to query, as this may not be the same as connection hostname | ||
| node_host = if config[:node_host] |
There was a problem hiding this comment.
to address the ABC size I'd move this into its own own function such as determine_hostname or set_hostname
majormoses
added
Status: Awaiting Response
Type: Enhancement
and removed
Feedback Requested
labels
|
@Infraded any chance you are gonna pick this back up? Last ping before closing out. |
|
closing due to inactivity, if there is desire to pick this up again we can re-open or create a new PR. |
Grissess
pushed a commit
to wherefortravel/sensu-plugins-rabbitmq
that referenced
this pull request
Nov 30, 2023
Prep for bonsai asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
Yes, fixes #43
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Existing check only looks at the first node in the node list. This leaves node health unknown for all other nodes in a cluster. This update allows the check to determine the running system's node name (using defaults matching RMQ), or allows it to be specified in the check definition.
Known Compatibility Issues