Skip to content

Conversation

@anatolyyyyyy
Copy link
Contributor

Fixes #78

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 13, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files           2        2           
  Lines         149      149           
=======================================
  Hits          148      148           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a0e80...56ccc02. Read the comment docs.

@devchas devchas added difficulty: easy fix is easy in difficulty good first issue type: docs update documentation change not affecting the code labels Oct 17, 2018
CONTRIBUTING.md Outdated

We welcome direct contributions to the smtpapi-python code base. Thank you!

Please note that we utilize the [Gitflow Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) for Git to help keep project development organized and consistent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use plain language:

Suggested change
Please note that we utilize the [Gitflow Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) for Git to help keep project development organized and consistent.
Please note that we use the [Gitflow Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) for Git to help keep project development organized and consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done

- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
- [ ] I have read the [Contribution Guide] and my PR follows them.
- [ ] I updated my branch with the master branch.
- [ ] I updated my branch with the development branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] I updated my branch with the development branch.
- [ ] I updated my branch with the `development` branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@anatolyyyyyy anatolyyyyyy force-pushed the update-contribution-gitflow branch from eb7073f to 56ccc02 Compare October 21, 2018 10:35
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 24, 2018
@thinkingserious
Copy link
Contributor

Hello @anatolyyyyyy,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 21239b1 into sendgrid:master Oct 30, 2018
@thinkingserious
Copy link
Contributor

Hello @anatolyyyyyy,

Thanks again for the PR!

You have earned 6 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@anatolyyyyyy anatolyyyyyy deleted the update-contribution-gitflow branch October 31, 2018 17:51
@eshanholtz eshanholtz changed the title Update contribution to use Gitflow workflow docs: Update contribution to use Gitflow workflow Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document new Git workflow in CHANGELOG.md

6 participants