Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update to_emails type #986

Merged
merged 1 commit into from
Apr 19, 2021
Merged

docs: Update to_emails type #986

merged 1 commit into from
Apr 19, 2021

Conversation

PyGeek03
Copy link
Contributor

@PyGeek03 PyGeek03 commented Apr 18, 2021 •
edited
Loading

Fixes

Update the type of Mail.to()'s parameter to_emails to match how this method accepts list of str and list of tuple for to_emails as well.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added inline documentation to the code I modified
  • I have added the necessary documentation about the functionality in the appropriate .md file

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@PyGeek03
Update to_emails type
841f76e 
Update the type of Mail.to()'s parameter to_emails to match how this method accepts list of str and list of tuple for to_emails as well.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 18, 2021
thinkingserious
thinkingserious approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thinkingserious thinkingserious merged commit cf0924c into sendgrid:main Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PyGeek03 @thinkingserious