Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add v3 bypass filters #983

Merged
merged 3 commits into from
Apr 9, 2021
Merged

feat: add v3 bypass filters #983

merged 3 commits into from
Apr 9, 2021

Conversation

anarayanan604
Copy link
Contributor

Fixes

Adds support for the following v3 suppression bypass filters, detailed here

  • bypass_spam_management
  • bypass_bounce_management
  • bypass_unsubscribe_management

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@anarayanan604
Add v3 suppression bypass filters to the MailSettings object
620f299 
- bypass_spam_management
- bypass_bounce_management
- bypass_unsubscribe_management
@anarayanan604
test cases
6999b38
@anarayanan604
Update kitchen_sink.md
b17b529
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 7, 2021
@anarayanan604 anarayanan604 mentioned this pull request Apr 7, 2021
Closed
eshanholtz
eshanholtz approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you for the contribution

@eshanholtz eshanholtz merged commit 16eb0c3 into sendgrid:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for v3 suppression bypass filters
3 participants
@anarayanan604 @eshanholtz @thinkingserious