Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Sending HTML email example is broken #962

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

mikeckennedy
Copy link
Contributor

Fixes

The code sample in sendgrid-python/blob/main/use_cases/sending_html_content.md were broken. There were two problems. One undefined variable(mail) and one runtime error (ValueError: Please use a To, Cc or Bcc object.).

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • [ x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x ] I have read the Contribution Guidelines and my PR follows them
  • [x ] I have titled the PR appropriately
  • [x ] I have updated my branch with the main branch
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added the necessary documentation about the functionality in the appropriate .md file
  • [x ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 20, 2020
@thinkingserious thinkingserious changed the title Sending HTML email example is broken docs: Sending HTML email example is broken Dec 28, 2020
@thinkingserious thinkingserious merged commit 74293fd into sendgrid:main Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants