Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document change in top-level dependencies #915

Merged
merged 3 commits into from
Jun 25, 2020
Merged

docs: document change in top-level dependencies #915

merged 3 commits into from
Jun 25, 2020

Conversation

honzajavorek
Copy link
Contributor

Follow-up to #914

This change adds information about top-level dependencies of the package
to various places of its docs.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@honzajavorek
docs: document change in top-level dependencies
05465c0 
This change adds information about top-level dependencies of the package
to various places of its docs.

Follow-up to sendgrid#914
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 25, 2020
@honzajavorek honzajavorek mentioned this pull request Jun 25, 2020
Closed
childish-sambino
childish-sambino approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino merged commit 6728946 into sendgrid:master Jun 25, 2020
@honzajavorek honzajavorek deleted the honzajavorek/fix-deps-list branch June 25, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honzajavorek @childish-sambino @thinkingserious