Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added docstrings to Stats classes #912

Merged
merged 1 commit into from
Jun 23, 2020
Merged

docs: added docstrings to Stats classes #912

merged 1 commit into from
Jun 23, 2020

Conversation

DougCal
Copy link
Contributor

@DougCal DougCal commented Jun 23, 2020 •
edited
Loading

Fixes #772

This adds docstrings to all the classes in the stats.py file.

  • I acknowledge that all my contributions will be made under the project's license

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 23, 2020
@DougCal
Copy link
Contributor Author

DougCal commented Jun 23, 2020

New to contributing to OSS, so totally open to feedback here. Thanks for making it easy for me to get started! 😁

@DougCal DougCal changed the title Added docstrings to Stats classes docs: added docstrings to Stats classes Jun 23, 2020
childish-sambino
childish-sambino approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add this to the summary and tick the box?

- [ ] I acknowledge that all my contributions will be made under the project's license

@DougCal
Copy link
Contributor Author

DougCal commented Jun 23, 2020

@childish-sambino updated the summary. Is that what you were looking for?

@childish-sambino
Copy link
Contributor

Yup, thanks!

@childish-sambino childish-sambino merged commit 3a001fc into sendgrid:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docstrings to stats.py
3 participants
@DougCal @childish-sambino @thinkingserious