Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prep the repo for automated releasing #862

Merged
merged 4 commits into from
Jan 16, 2020
Merged

chore: prep the repo for automated releasing #862

merged 4 commits into from
Jan 16, 2020

Conversation

eshanholtz
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 15, 2020
.travis.yml Show resolved Hide resolved
@@ -1,2 +1 @@
version_info = (6, 1, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if clients used version_info at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was used to build __version__ (don't know why though), which is used here: https://github.com/sendgrid/sendgrid-python/blob/master/setup.py#L21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, need to update this:

if sys.version_info[:3] >= (3, 5, 0):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkingserious sys.version_info returns the separated python version information. It seemed like it was only used to build the __version__ number in version.py, per your previous comment.

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #862 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
- Coverage   80.02%   79.92%   -0.11%     
==========================================
  Files          70       70              
  Lines        2018     2017       -1     
  Branches      339      338       -1     
==========================================
- Hits         1615     1612       -3     
- Misses        204      206       +2     
  Partials      199      199
Impacted Files Coverage Δ
sendgrid/version.py 100% <100%> (ø) ⬆️
sendgrid/helpers/mail/email.py 92.59% <0%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c500f4...f2521fa. Read the comment docs.

@eshanholtz eshanholtz merged commit 6fe402c into master Jan 16, 2020
@eshanholtz eshanholtz deleted the librarian branch January 16, 2020 20:57
@thinkingserious
Copy link
Contributor

Hello @eshanholtz,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants