-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prep the repo for automated releasing #862
Conversation
@@ -1,2 +1 @@ | |||
version_info = (6, 1, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if clients used version_info
at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was used to build __version__
(don't know why though), which is used here: https://github.com/sendgrid/sendgrid-python/blob/master/setup.py#L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, need to update this:
if sys.version_info[:3] >= (3, 5, 0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thinkingserious sys.version_info
returns the separated python version information. It seemed like it was only used to build the __version__
number in version.py
, per your previous comment.
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
- Coverage 80.02% 79.92% -0.11%
==========================================
Files 70 70
Lines 2018 2017 -1
Branches 339 338 -1
==========================================
- Hits 1615 1612 -3
- Misses 204 206 +2
Partials 199 199
Continue to review full report at Codecov.
|
Hello @eshanholtz, |
No description provided.