Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert integer substitution value to string #838

Conversation

lifez
Copy link
Contributor

@lifez lifez commented Sep 12, 2019

Fixes #805

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Convert value of substitution to string if it is integer

If you have questions, please send an email to Twilio SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #838 into master will decrease coverage by 16.55%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #838       +/-   ##
===========================================
- Coverage   80.02%   63.47%   -16.56%     
===========================================
  Files          70       70               
  Lines        2018     2018               
  Branches      339      339               
===========================================
- Hits         1615     1281      -334     
- Misses        204      605      +401     
+ Partials      199      132       -67
Impacted Files Coverage Δ
sendgrid/helpers/mail/substitution.py 82.14% <100%> (-7.15%) ⬇️
sendgrid/helpers/mail/ganalytics.py 31.37% <0%> (-64.71%) ⬇️
sendgrid/helpers/mail/custom_arg.py 32.14% <0%> (-57.15%) ⬇️
sendgrid/helpers/mail/subscription_tracking.py 26.82% <0%> (-53.66%) ⬇️
sendgrid/helpers/mail/footer_settings.py 28.12% <0%> (-53.13%) ⬇️
sendgrid/helpers/mail/section.py 33.33% <0%> (-52.39%) ⬇️
sendgrid/helpers/mail/bcc_settings.py 30.43% <0%> (-52.18%) ⬇️
sendgrid/helpers/mail/open_tracking.py 30.43% <0%> (-52.18%) ⬇️
sendgrid/helpers/mail/bypass_list_management.py 35.71% <0%> (-50.01%) ⬇️
sendgrid/helpers/mail/sandbox_mode.py 35.71% <0%> (-50.01%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021a9dc...0fe96a9. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #838 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          70       70           
  Lines        2018     2018           
  Branches      339      339           
=======================================
  Hits         1615     1615           
  Misses        204      204           
  Partials      199      199
Impacted Files Coverage Δ
sendgrid/helpers/mail/substitution.py 89.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021a9dc...0fe96a9. Read the comment docs.

@thinkingserious thinkingserious merged commit 076f376 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @lifez,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Convert integer substitution value to string fix: Convert integer substitution value to string Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert integer Substitution values to strings
2 participants