Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Key typo #797

Merged
merged 2 commits into from
Apr 30, 2019
Merged

API Key typo #797

merged 2 commits into from
Apr 30, 2019

Conversation

thinkingserious
Copy link
Contributor

Fixes #791

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: ready for merge code deemed fit for merge status: code review request requesting a community code review or review from Twilio labels Apr 30, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #797 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage      80%   79.26%   -0.75%     
==========================================
  Files          69       69              
  Lines        2016     2016              
  Branches      338      334       -4     
==========================================
- Hits         1613     1598      -15     
- Misses        204      218      +14     
- Partials      199      200       +1
Impacted Files Coverage Δ
sendgrid/helpers/inbound/app.py 60.86% <0%> (-17.4%) ⬇️
sendgrid/helpers/mail/email.py 83.95% <0%> (-11.12%) ⬇️
sendgrid/helpers/inbound/send.py 87.5% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea796fb...98f187a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #797 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage      80%   79.26%   -0.75%     
==========================================
  Files          69       69              
  Lines        2016     2016              
  Branches      338      334       -4     
==========================================
- Hits         1613     1598      -15     
- Misses        204      218      +14     
- Partials      199      200       +1
Impacted Files Coverage Δ
sendgrid/helpers/inbound/app.py 60.86% <0%> (-17.4%) ⬇️
sendgrid/helpers/mail/email.py 83.95% <0%> (-11.12%) ⬇️
sendgrid/helpers/inbound/send.py 87.5% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea796fb...98f187a. Read the comment docs.

@thinkingserious thinkingserious merged commit 5a60281 into master Apr 30, 2019
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious deleted the thinkingserious-patch-3 branch September 11, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio status: ready for merge code deemed fit for merge type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api_key SendGridAPIClient key still present in documentation file
1 participant