Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #790 #792

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Fix #790 #792

merged 3 commits into from
Apr 30, 2019

Conversation

johnpkennedy
Copy link

@johnpkennedy johnpkennedy commented Apr 28, 2019

Fixes #790

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

Allow Unicode strings for the name associated with the email.

If you have questions, please send an email to Twilio SendGrid, or file a GitHub Issue in this repository.

Allow Unicode strings for the name associated with the email.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 28, 2019
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #792 into master will increase coverage by 0.03%.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #792      +/-   ##
========================================
+ Coverage   79.97%    80%   +0.03%     
========================================
  Files          69     69              
  Lines        2012   2016       +4     
  Branches      338    338              
========================================
+ Hits         1609   1613       +4     
  Misses        204    204              
  Partials      199    199
Impacted Files Coverage Δ
sendgrid/helpers/mail/email.py 95.06% <80%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266c2ab...0cdcb2c. Read the comment docs.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: bug bug in the library labels Apr 30, 2019
@thinkingserious thinkingserious merged commit ea796fb into sendgrid:master Apr 30, 2019
@thinkingserious
Copy link
Contributor

Hello @johnpkennedy,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError "name must be of type string" regression when name is Unicode string
2 participants