Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updation in prerequisites #718

Merged
merged 1 commit into from
Nov 18, 2018
Merged

Updation in prerequisites #718

merged 1 commit into from
Nov 18, 2018

Conversation

Rishabh04-02
Copy link
Contributor

#717

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

On the website its mentioned that Send up to 40,000 emails for 30 days, then send 100 emails/day free forever but it has not been mentioned in the README.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          983      983           
  Misses         90       90           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb4cc...3f3eba4. Read the comment docs.

@thinkingserious
Copy link
Contributor

Hello @Rishabh04-02,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 265b984 into sendgrid:master Nov 18, 2018
@thinkingserious
Copy link
Contributor

Hello @Rishabh04-02,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants