-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Give preference to 'to' after visible #714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 85.03% 85.03%
=======================================
Files 35 35
Lines 1156 1156
Branches 172 172
=======================================
Hits 983 983
Misses 90 90
Partials 83 83 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a typo? Maybe I'm wrong but the sentence seems to read fine without changing by
-> to
?
The preposition after visible is usually |
So it's not really a typo but more of a preference? |
Yes, it's more of a preference and I have changed the commit message accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please rebase this against the v4 branch? Thanks!
Hello @agarwalrounak, |
Fixes
Checklist
Short description of what this PR does:
If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.