Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Give preference to 'to' after visible #714

Merged
merged 1 commit into from
Mar 6, 2020
Merged

docs: Give preference to 'to' after visible #714

merged 1 commit into from
Mar 6, 2020

Conversation

agarwalrounak
Copy link
Contributor

@agarwalrounak agarwalrounak commented Oct 27, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Replaces "visible by recipient" by "visible to recipient"

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 27, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          983      983           
  Misses         90       90           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb4cc...6c26b6d. Read the comment docs.

Copy link

@42B 42B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a typo? Maybe I'm wrong but the sentence seems to read fine without changing by -> to?

@agarwalrounak
Copy link
Contributor Author

The preposition after visible is usually to when referring to something being visible to someone.
https://lingohelp.me/preposition-after-adjective/visible-in-or-visible-to/

@42B
Copy link

42B commented Oct 27, 2018

So it's not really a typo but more of a preference?

@agarwalrounak agarwalrounak changed the title Fix typo Give preference to 'to' after visible Oct 27, 2018
@agarwalrounak
Copy link
Contributor Author

Yes, it's more of a preference and I have changed the commit message accordingly.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code and removed status: code review request requesting a community code review or review from Twilio labels Oct 30, 2018
Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please rebase this against the v4 branch? Thanks!

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 31, 2018
@thinkingserious
Copy link
Contributor

Hello @agarwalrounak,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Give preference to 'to' after visible docs: Give preference to 'to' after visible Mar 6, 2020
@childish-sambino childish-sambino merged commit ea90f7c into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants