Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Dockerfile's #711

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

rawkode
Copy link
Contributor

@rawkode rawkode commented Oct 26, 2018

This commit tries to remove as many redundant layers as possible, while
still maintaining readability.

This commit tries to remove as many redundant layers as possible, while
still maintaining readability.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 26, 2018
@rawkode
Copy link
Contributor Author

rawkode commented Oct 26, 2018

I reckon I can consolidate these Dockerfile's into a single one, using multi-stage builds; but this will require additional pull requests.

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #711 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #711   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          36       36           
  Lines         965      965           
  Branches      107      107           
=======================================
  Hits          814      814           
  Misses         93       93           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd02e4...ef0c8e0. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 30, 2018
@misterdorm misterdorm added the difficulty: medium fix is medium in difficulty label Oct 30, 2018
@thinkingserious thinkingserious added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 31, 2018
@thinkingserious
Copy link
Contributor

Hello @rawkode,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added the type: community enhancement feature request not on Twilio's roadmap label Oct 31, 2018
@thinkingserious thinkingserious merged commit d041c44 into sendgrid:v4 Oct 31, 2018
@rawkode rawkode deleted the bugfix/docker-ddev branch October 31, 2018 08:43
@thinkingserious
Copy link
Contributor

Hello @rawkode,

Thanks again for the PR!

You have earned 15 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants