PEP8 Fixes and String Formatting Enhancement #697
Conversation
thinkingserious
added
the
status: code review request
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 84.77% 85.04% +0.27%
==========================================
Files 35 35
Lines 1156 1157 +1
Branches 172 172
==========================================
+ Hits 980 984 +4
Misses 90 90
+ Partials 86 83 -3
Continue to review full report at Codecov.
|
|
hi @misterdorm, |
|
Replaces #673 |
misterdorm
added
status: work in progress
|
@misterdorm, |
|
@misterdorm |
|
@42B @misterdorm |
test/test_sendgrid.py
Outdated
| @@ -144,8 +144,11 @@ def test_hello_world(self): | |||
| content = Content( | |||
| "text/plain", "and easy to do anywhere, even with Python") | |||
| mail = Mail(from_email, subject, to_email, content) | |||
| self.assertTrue(mail.get() == {'content': [{'type': 'text/plain', 'value': 'and easy to do anywhere, even with Python'}], 'personalizations': [ | |||
| {'to': [{'email': '[email protected]'}]}], 'from': {'email': '[email protected]'}, 'subject': 'Sending with SendGrid is Fun'}) | |||
| self.assertTrue(mail.get() == { | |||
There was a problem hiding this comment.
@42B
I have updated file with master branch. This file was changed when merged with others PR.
May be this PR was at the time of github outage period.
| mail.get() == {'content': [{'type': 'text/plain', 'value': 'and easy to do anywhere, even with Python'}], | ||
| 'personalizations': [ | ||
| {'to': [{'email': '[email protected]'}]}], 'from': {'email': '[email protected]'}, | ||
| 'subject': 'Sending with SendGrid is Fun'}) |
There was a problem hiding this comment.
It still seems like this should be changed from self.assertTrue to self.assertEqual? Maybe something like this?
self.assertEqual(mail.get(), {
'content': [{
'type': 'text/plain',
'value': 'and easy to do anywhere, even with Python'
}],
'personalizations': [{
'to': [{'email': '[email protected]'}]
}],
'from': {'email': '[email protected]'},
'subject': 'Sending with SendGrid is Fun'
})There was a problem hiding this comment.
@42B
You can create a new issue for this. I used the same code from master.
thinkingserious
added
status: ready for deploy
|
Hello @vkmrishad, |
|
@thinkingserious @misterdorm @42B |
Checklist
Short description of what this PR does:
If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.